Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide scrollbar of primary sidebar #1672

Open
jnywong opened this issue Nov 25, 2024 · 2 comments
Open

Hide scrollbar of primary sidebar #1672

jnywong opened this issue Nov 25, 2024 · 2 comments
Labels
enhancement New feature or request

Comments

@jnywong
Copy link
Contributor

jnywong commented Nov 25, 2024

Proposal

Hellooo! I was updating my MyST website with the book theme enabled and noticed that the scrollbar of the expanded navigation menu on the left side was distractingly visible, especially in dark mode.

Before:

before-scrollbar.mp4

I propose to update the navigation scrollbar to a dark theme when switching to dark mode.

Additional notes

See PR jupyter-book/myst-theme#502.

@jnywong
Copy link
Contributor Author

jnywong commented Nov 26, 2024

Pasted from jupyter-book/myst-theme#502

Happy to make a pr, but need some pointers on where to start because the light/dark mode theme switcher looks a little more complicated to contribute to at first glance.

@agoose77
Copy link
Contributor

agoose77 commented Nov 26, 2024

@jnywong yeah, if you're needing to change the DOM according to the theme, it is fiddly. But if it's just CSS changes, then you can use tailwind dark: selector to set a style that only applies for dark themes.

I can definitely provide some pointers - will take a peek tomorrow.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants