Skip to content

Commit

Permalink
Merge pull request #1035 from minrk/reverse-internal-get
Browse files Browse the repository at this point in the history
fix arg order in github internal_get
  • Loading branch information
minrk authored Jan 12, 2023
2 parents 8a64fe4 + 33f7320 commit 8b013f7
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion nbviewer/providers/github/handlers.py
Original file line number Diff line number Diff line change
Expand Up @@ -198,7 +198,7 @@ def render_treelist_template(
**namespace,
)

async def _internal_get(self, user: str, repo: str, path: str, ref: str) -> str:
async def _internal_get(self, user: str, repo: str, ref: str, path: str) -> str:
"""
Hook into here later during testing – probably via a CLI.
Do avoid doing actual github requests.
Expand Down

2 comments on commit 8b013f7

@gracechuan2
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

My nbviewer page for a specific notebook of mine use to render all my graphics perfectly but now they are distorted. https://nbviewer.org/github/gracechuan2/contagion/blob/main/Network%20Contagion%20Simulations_final.ipynb
I am not sure if this change or latest update could be the reason behind this. Would love to get this fixed somehow as it is linked to a research paper of mine! Thank you.

@minrk
Copy link
Member Author

@minrk minrk commented on 8b013f7 Jan 26, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gracechuan2 this is likely due to an update to nbconvert, which was deployed recently. If you can open an issue on https://github.com/jupyter/nbconvert with a link to the notebook whose output changed, we may be able to find a bug in the updated outputs.

Please sign in to comment.