From f4ce9bdfc215e66e39db9a131ccaa675a2540a22 Mon Sep 17 00:00:00 2001 From: YuviPanda Date: Thu, 25 Jul 2024 18:15:09 -0700 Subject: [PATCH] Remove warning about only supporting go-jsonnet I've always used the regular jsonnet implementation without trouble, and continue to do so. It's technically slower, but at these scales it does not matter. It's also the default you get if you do `brew install jsonnet` or `apt install jsonnet`. --- deploy.py | 8 +------- 1 file changed, 1 insertion(+), 7 deletions(-) diff --git a/deploy.py b/deploy.py index 24be9e5..cb870bb 100755 --- a/deploy.py +++ b/deploy.py @@ -130,18 +130,12 @@ def main(): "The environment variable GRAFANA_TOKEN needs to be set in order to deploying dashboards to a Grafana deployment." ) - # ensure jsonnet (go-jsonnet) + # ensure jsonnet if not shutil.which("jsonnet"): raise ValueError( "No jsonnet binary was found on path! " "Install go-jsonnet via https://github.com/google/go-jsonnet/releases." ) - jsonnet_version = subprocess.check_output(["jsonnet", "--version"], text=True) - if "go" not in jsonnet_version.casefold(): - print( - "WARNING: The jsonnet binary on path doesn't seem to be go-jsonnet from https://github.com/google/go-jsonnet/releases! " - "Only that jsonnet implementation is known to work." - ) api = partial( grafana_request,