Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove warning about only supporting go-jsonnet #137

Merged
merged 1 commit into from
Jul 29, 2024
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions deploy.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,18 +130,12 @@ def main():
"The environment variable GRAFANA_TOKEN needs to be set in order to deploying dashboards to a Grafana deployment."
)

# ensure jsonnet (go-jsonnet)
# ensure jsonnet
if not shutil.which("jsonnet"):
raise ValueError(
"No jsonnet binary was found on path! "
"Install go-jsonnet via https://github.com/google/go-jsonnet/releases."
)
jsonnet_version = subprocess.check_output(["jsonnet", "--version"], text=True)
if "go" not in jsonnet_version.casefold():
print(
"WARNING: The jsonnet binary on path doesn't seem to be go-jsonnet from https://github.com/google/go-jsonnet/releases! "
"Only that jsonnet implementation is known to work."
)

api = partial(
grafana_request,
Expand Down