Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show dropdown in profile_options if only unlisted_choice is enabled, no choices are present #756

Open
yuvipanda opened this issue Jul 24, 2023 · 0 comments
Open

Don't show dropdown in profile_options if only unlisted_choice is enabled, no choices are present #756

yuvipanda opened this issue Jul 24, 2023 · 0 comments

Comments

@yuvipanda
Copy link
Collaborator

Follow-up to #735 (comment), if a profile_option is configured to have unlisted_choice.enabled to True, but choices is not set, we currenlty show a dropdown with just 'Other' as an option. This is kinda ugly. Instead, it should just not show the dropdown at all.
@yuvipanda yuvipanda mentioned this issue Jul 24, 2023
Merged
batpad added a commit to batpad/kubespawner that referenced this issue Sep 2, 2023
@batpad
Towards jupyterhub#756 and jupyterhub#757 -
e041fab 
 - Allows for an `other_text` option inside `unlisted_choice` which allows user to specify a custom text in the select drop-down
 - Hide select drop-down and label if no choices are defined
@batpad batpad mentioned this issue Sep 2, 2023
Closed
batpad added a commit to batpad/kubespawner that referenced this issue Sep 2, 2023
@batpad
Refs jupyterhub#756 - allow dropdown text for unlisted choice to be c…
8697732 
…onfigurable
@batpad batpad mentioned this issue Sep 2, 2023
Merged
@consideRatio consideRatio mentioned this issue Sep 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@yuvipanda