Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stop hardcoding reflectors to monitor component: singleuser-server label #834

Open
consideRatio opened this issue Apr 24, 2024 · 0 comments
Labels

Comments

@consideRatio
Copy link
Member

consideRatio commented Apr 24, 2024

We have hardcoded kubespawner to monitor pods with the label component: singleuser-server. It would be good if we instead allowed what we search for to be configurable. I know this has been relevant for a minority of z2jh users who wanted to deploy multiple hubs in the same k8s namespace for example, but I'd also like it so that we can update the old label scheme component to the modern app.kubernetes.io/component label.

I think we should introduce a configuration to represent what pods we monitor and manage based on label selection.

Related

  • KubeSpawner.component_label configuration
  • k8s matchLabels, for Deployment resources for example, declaring how they via labels identify the resources they are controlling
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant