diff --git a/schema/plugin.json b/schema/plugin.json index b46ba41..c304f09 100644 --- a/schema/plugin.json +++ b/schema/plugin.json @@ -138,7 +138,7 @@ { "selector": ".jp-NotebookPanel[data-jp-vim-mode='true'][data-jp-vim-shift-esc-override-browser='true'] .jp-Notebook.jp-mod-commandMode", "keys": ["Shift Escape"], - "command": "" + "command": "vim:no-action" }, { "selector": ".jp-NotebookPanel[data-jp-vim-mode='true'] .jp-Notebook:focus", diff --git a/src/labCommands.ts b/src/labCommands.ts index e06194b..2de2a1f 100644 --- a/src/labCommands.ts +++ b/src/labCommands.ts @@ -166,7 +166,7 @@ export function addNotebookCommands( isEnabled }), commands.addCommand('vim:leave-current-mode', { - label: 'Move Insert to Normal to Jupyter Command Mode"', + label: 'Move Insert to Normal to Jupyter Command Mode', execute: args => { const current = getCurrent(args); @@ -284,6 +284,14 @@ export function addNotebookCommands( } }, isEnabled + }), + commands.addCommand('vim:no-action', { + label: 'Prevent Default Browser Action', + caption: + 'Prevent default action for some keybindings (defined in the settings); for example Firefox binds Shift + Esc to its Process Manager which conflicts with the expected action in the vim mode.', + execute: args => { + // no-op + } }) ]; return addedCommands;