-
Notifications
You must be signed in to change notification settings - Fork 84
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add jom compiler setup #10
Conversation
800b98a
to
f50ede6
Compare
Not sure why this fails: |
exec has no shell, see actions/toolkit#229 |
@jurplel I am new to typescript. I found these two packages (download-file and extract-zip) which I used in the code. It is still unclear to me where I can tell the github-action to install the two dependencies. |
@LorenzE, I added a PR to your repo that should fix the dependency issues. One meta discussion item: should it be the role of |
I was planning to do it from |
@miurahr any plans to include jom installation to aqtinstall on windows? |
src/main.ts
Outdated
// users will want it. | ||
if (process.platform == "win32" && core.getInput("install-deps") == "true") { | ||
const download = require('download') | ||
var url = "http://download.qt.io/official_releases/jom/jom.zip" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
var url = "http://download.qt.io/official_releases/jom/jom.zip" | |
var url = "https://download.qt.io/official_releases/jom/jom.zip" |
Use SSL.
Hope GithubAction env will take of this afterall actions/runner-images#135 |
It was rejected, perhaps you could consider reopening this pull request? |
Closes #7