Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add jom compiler setup #10

Closed
wants to merge 8 commits into from
Closed

Add jom compiler setup #10

wants to merge 8 commits into from

Conversation

LorenzE
Copy link
Contributor

@LorenzE LorenzE commented Nov 25, 2019

Closes #7

@LorenzE LorenzE force-pushed the jom branch 3 times, most recently from 800b98a to f50ede6 Compare November 25, 2019 19:11
@LorenzE
Copy link
Contributor Author

LorenzE commented Nov 25, 2019

Not sure why this fails: await exec.exec('wget http://download.qt.io/official_releases/jom/jom.zip -OutFile jom.zip'). Any ideas @jurplel?

@jurplel
Copy link
Owner

jurplel commented Nov 25, 2019

exec has no shell, see actions/toolkit#229

try using https://www.npmjs.com/package/download-file

@LorenzE
Copy link
Contributor Author

LorenzE commented Nov 26, 2019

@jurplel I am new to typescript. I found these two packages (download-file and extract-zip) which I used in the code. It is still unclear to me where I can tell the github-action to install the two dependencies.

@linville
Copy link
Contributor

@LorenzE, I added a PR to your repo that should fix the dependency issues.

One meta discussion item: should it be the role of install-qt-action to install Jom or should it be something preferably handled upstream by aqtinstall?

@jurplel
Copy link
Owner

jurplel commented Nov 28, 2019

I was planning to do it from install-qt-action but if aqtinstall adds it, then i would prefer using that.

@LorenzE
Copy link
Contributor Author

LorenzE commented Nov 28, 2019

@miurahr any plans to include jom installation to aqtinstall on windows?

src/main.ts Outdated
// users will want it.
if (process.platform == "win32" && core.getInput("install-deps") == "true") {
const download = require('download')
var url = "http://download.qt.io/official_releases/jom/jom.zip"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
var url = "http://download.qt.io/official_releases/jom/jom.zip"
var url = "https://download.qt.io/official_releases/jom/jom.zip"

Use SSL.

@LorenzE
Copy link
Contributor Author

LorenzE commented Feb 18, 2020

Hope GithubAction env will take of this afterall actions/runner-images#135

@LorenzE LorenzE closed this Feb 18, 2020
@isaak654
Copy link

Hope GithubAction env will take of this afterall actions/runner-images#135

It was rejected, perhaps you could consider reopening this pull request?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Install jom automatically on windows
4 participants