chore: url path after OMP switch #1770
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Review changes with |
gitanjli525
added
S-waiting-on-review
gitanjli525
changed the title
src/utils/GlobalVars.res
Outdated
Comment on lines
32
to
40
| let extractModulePath = (url: RescriptReactRouter.url) => { | ||
| let currentPathList = url.path->List.toArray | ||
| let path = switch currentPathList->Array.get(0) { | ||
| | Some("dashboard") => currentPathList->Array.slice(~start=0, ~end=2)->Array.joinWith("/") | ||
| | _ => currentPathList->LogicUtils.getValueFromArray(0, "home") | ||
| } | ||
| appendTrailingSlash(path) | ||
| } | ||
|
|
There was a problem hiding this comment.
Suggested change
| let extractModulePath = (url: RescriptReactRouter.url) => { | |
| let currentPathList = url.path->List.toArray | |
| let path = switch currentPathList->Array.get(0) { | |
| | Some("dashboard") => currentPathList->Array.slice(~start=0, ~end=2)->Array.joinWith("/") | |
| | _ => currentPathList->LogicUtils.getValueFromArray(0, "home") | |
| } | |
| appendTrailingSlash(path) | |
| } | |
| let extractModulePath = (url: RescriptReactRouter.url) => { | |
| let currentPathList = url.path->List.toArray | |
| let path = switch currentPathList->Array.get(0) { | |
| | Some("dashboard") => currentPathList->Array.slice(~start=0, ~end=2)->Array.joinWith("/") | |
| | _ => currentPathList->LogicUtils.getValueFromArray(0, "home") | |
| } | |
| appendTrailingSlash(path) | |
| } | |
| let extractModulePath = (url: RescriptReactRouter.url) => { | |
| url.path->List.toArray->Array.slice(~start=0, ~end=2)->Array.joinWith("/")->appendTrailingSlash | |
| } |
JeevaRamu0104
approved these changes
Nov 25, 2024
github-actions
bot
added
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of Change
Description
currently on profile switch user is always redirected to home page
with this change - on profile switch the user will land on the same subsection link
for org and merchant switch
currently: for the url that does not exist it shows error page and for others it goes to home page
with this change: same behaviour as on profile switch (will land on the same subsection link )
suppose url is
/payments/pay_eHqoQH7t3efEazeiEXu2/pro_IJGV7MaFtoDvI9P5Ri0hit will be redirected to/paymentsand so on, this ensures that user does not see any error and still remains under same module after switch
Motivation and Context
improving user experience
How did you test it?
Where to test it?
Checklist
npm run re:build