om health: Shell dotfiles are Nix-managed

[rsrohitsingh682]

resolves #299

[srid]

@rsrohitsingh682 Could you post screenshots of the behaviour on macOS, Linux and on some system where neither bash nor zsh is the current shell?

[rsrohitsingh682]

@rsrohitsingh682 Could you post screenshots of the behaviour on macOS, Linux and on some system where neither bash nor zsh is the current shell?

MacOS where zsh is managed by nix.

MacOS where zsh is not managed by nix.

Linux (Ubuntu) where bash is not managed by nix.

[srid]

I think the struct encapsulation can still be improved (for one thing, you only need one struct not two). But the best way to understand why is to answer this question: How does this behave under the following situations?

• User's shell is neither bash nor zsh. Its dotfiles are not managed by Nix.
• User's shell is neither bash nor zsh. Its dotfiles are managed by Nix.

[rsrohitsingh682]

I think the struct encapsulation can still be improved (for one thing, you only need one struct not two). But the best way to understand why is to answer this question: How does this behave under the following situations?

• User's shell is neither bash nor zsh. Its dotfiles are not managed by Nix.
• User's shell is neither bash nor zsh. Its dotfiles are managed by Nix.

For both the cases it would return false and say it is not managed by Nix which would be wrong for the second part. Now when I think about it I am checking only dotfiles but for shells like fish the configurations are present in ~/.config/fish/config.fish. So ideally I should maintain a list where I can refer to the correct place be it .dotfiles or config files.

[rsrohitsingh682]

@srid The CI seems to be failing for aarch64-darwin while running tests.

For checking the shell configuration it is looking into

/var/lib/github-runners/sambar-juspay-08/.bashrc

Any thoughts on this ?

[srid]

That's because in CI $HOME is /var/lib/github-runners/sambar-juspay-08/.

How are you handling the case of a dotfile not even existing in the first place?

[rsrohitsingh682]

That's because in CI $HOME is /var/lib/github-runners/sambar-juspay-08/.

How are you handling the case of a dotfile not even existing in the first place?

https://github.com/juspay/omnix/pull/306/files#diff-f499d0e179c61c3e80fd0d383c0d1574dd411dba6cb707c91bde716d75308709R129

[srid]

Should a missing dotfile cause omnix to panic, or should it cause health check to fail?

[rsrohitsingh682]

Should a missing dotfile cause omnix to panic, or should it cause health check to fail?

If I am able to determine user's default shell, in this case I am and after that if I am not able to find dotfile (in this case because of permission issue I guess), omnix should panic.

From our last discussion,
if user's shell is not supported then I can cause the health check to fail and for other reasons like $HOME or $SHELL is not set then it should panic. And I think not able to find dotfile is could also be the reason to panic. I mean this is my understanding, I could be wrong though.

[srid]

A missing dotfile is a legitimate use case. It should fail the health check, rather than panic. Then, if this check is required=false, the CI would not fail.

[rsrohitsingh682]

A missing dotfile is a legitimate use case. It should fail the health check, rather than panic. Then, if this check is required=false, the CI would not fail.

Got it. I will make those changes then.

[srid]

@rsrohitsingh682 Could you post screenshots of the behaviour on macOS, Linux and on some system where neither bash nor zsh is the current shell?

Answer: behaviour when using fish:

[rsrohitsingh682]

@rsrohitsingh682 Could you post screenshots of the behaviour on macOS, Linux and on some system where neither bash nor zsh is the current shell?

Answer: behaviour when using fish:

This was because of the below commit.

5aaa25e#diff-f499d0e179c61c3e80fd0d383c0d1574dd411dba6cb707c91bde716d75308709R95-R97

[srid]

@rsrohitsingh682 Yes, this is how we want it to behave.