DSW-1314 All component props are marked as optional #1106
fernandofranca
started this conversation in
General
Replies: 0 comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
-
This is about the changes introduced by this PR.
I released the dev package of each component updated with the suggestions from the DSW-1314 ticket description, then added the components to the
pie-aperture
repo, then checked on VSCode.Basically all components are now displaying some TS error.
I can list some below, and if you prefer can checkout the branch
dsw-1314-pie-wrapper-react-props
onpie-aperture
.PieLink
After removing all props and children it changes to:
PieDivider
Adding variant and orientation props solves the error.
PieButton
PieIconButton
PieCard
Beta Was this translation helpful? Give feedback.
All reactions