-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
test(pie-link): DSW-2229 updated visual tests to split by size #1952
Conversation
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Change looks good. I checked in Percy and shows missing images that I assume are the old ones, but confused on why it shows as missing instead of removed. Is this a known issue to us?
@maledr5 Yep "missing" is just the terminology used. As long as we're happy that only the removed screenshots are missing then that's all good. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment
Describe your changes (can list changeset entries if preferable)
This is to resolve issues such as:
Author Checklist (complete before requesting a review)
Reviewer checklists (complete before approving)
Reviewer 1 @maledr5
Reviewer 2 @kevinrodrigues