Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci(pie-storybook): DSW-2496 updated closed.yml #2083

Merged
merged 1 commit into from
Nov 20, 2024

Conversation

JoshuaNg2332
Copy link
Contributor

@JoshuaNg2332 JoshuaNg2332 commented Nov 20, 2024

Describe your changes (can list changeset entries if preferable)

  • Updated closed.yml to fix closing of test amplify deployments

Author Checklist (complete before requesting a review)

  • I have performed a self-review of my code

@JoshuaNg2332 JoshuaNg2332 requested review from a team as code owners November 20, 2024 11:04
Copy link

changeset-bot bot commented Nov 20, 2024

⚠️ No Changeset found

Latest commit: 4612f42

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the ci label Nov 20, 2024
@siggerzz siggerzz requested a review from Copilot November 20, 2024 11:14

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 1 out of 1 changed files in this pull request and generated no suggestions.

Comments skipped due to low confidence (2)

.github/workflows/closed.yml:41

  • The variable declaration contains a typo. It should be 'const' instead of 'cosnt'.
cosnt hasStorybookTestingEnv = envList.includes(`storybook-testing-pr-${pull_number}`);

.github/workflows/closed.yml:73

  • [nitpick] The condition checks for 'hasStorybookEnv' instead of 'hasStorybookTestingEnv'. This might not be the intended behavior.
if: steps.list-environments.outputs.hasStorybookEnv == 'true'
@siggerzz siggerzz merged commit 4a148b6 into main Nov 20, 2024
26 of 30 checks passed
@siggerzz siggerzz deleted the DSW-2496-fix-test-deploy-close branch November 20, 2024 11:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants