High memory Usage

[solunafantasy]

Feature Description

I am seeing extreme memory usage, more notable when adding 2.5K songs in queue. I first noticed this when Spotify and browsers crashed due to being out of memory, ( I don't normally use a page-file, I have 32GB of RAM)

Justification

Better memory management will avoid systemwide issues/improve performance. This is Windows 11, latest patch and 1.0.2. I am unsure if other versions are affected. I only noticed this after loading a larger then usual list. (since that seems to be working now)

Additional Information

[solunafantasy]

In the Interm, I have added 64GB of page-file on an SSD to mitigate to continue operation. I also have stopped adding songs until the current queue is exhausted. (I believe i have 5-6k still being added) Obviously not optimal but will allow the app to run for now. It would be a major PIA to requeue everything. I could imagine that this will degrade the app once it starts being utilized.

[justin025]

Does the amount stay high until the app is closed or does clearing items in the download queue fix the issue.

…

On Sunday, November 10th, 2024 at 9:30 AM, solunafantasy ***@***.***> wrote: In the Interm, I have added 64GB of page-file on an SSD to mitigate to continue operation. Obviously not optimal but will allow the app to run for now. I could imagine that this will degrade the app once it starts being utilized. — Reply to this email directly, [view it on GitHub](#53 (comment)), or [unsubscribe](https://github.com/notifications/unsubscribe-auth/BESVWLMMWE6DKIVBJI3INHDZ74RUPAVCNFSM6AAAAABRQAYRXGVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDINRWGY2TQNRRG4). You are receiving this because you are subscribed to this thread.Message ID: ***@***.***>

[solunafantasy]

It drops from 20GB to 13GB of ram after I clear completed downloads. Apologies it took so long to respond, i was afk all day. Surprisingly, it never crashed. Keep in mind only a third of the queue completed and its continuing to download.

[0rkaM]

Why on Task Manager says you have two instances running? Mine even when is in the middle of downloading, or creating the file, it shows only one instance.
And in my case, I cannot reproduce, even with a list of over 300+ queued songs, it does not go much over 260mb:

I save file as OGG, I wonder if maybe you are using another format and that is where it happens.

[solunafantasy]

Why on Task Manager says you have two instances running? Mine even when is in the middle of downloading, or creating the file, it shows only one instance. And in my case, I cannot reproduce, even with a list of over 300+ queued songs, it does not go much over 260mb: I save file as OGG, I wonder if maybe you are using another format and that is where it happens.

Microsoft Edge.......

Anyway, I am not sure, possibly because I renamed the file?

[justin025]

The latest commit substantially reduced the memory usage on my end, ~2.3GB for 625 songs down to ~270mb (290mb with download queue thumbnails). Clearing download queue still doesn't clear memory used by the deleted widgets, so I'll hold off on closing this issue until I can find an acceptable solution.

The bulk of the usage was in the icons on various buttons, I didn't think much of it because the png files themselves are only a couple hundred bytes large but I suppose pyqt does something to them in the background with QIcon which causes them to use additional memory. The app now reuses icons, instead of making 625 spotify icons for 625 songs it makes 1.

---

*Just a note for any users who are attempting to use onthespot on a low spec pc, the cli interface sits at ~90mb regardless of the number of songs queued.