Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Saving a template does not Hot Module Reload #2

Open
justrhysism opened this issue Mar 1, 2022 · 4 comments
Open

Saving a template does not Hot Module Reload #2

justrhysism opened this issue Mar 1, 2022 · 4 comments

Comments

@justrhysism
Copy link
Owner

No description provided.

@doctyper
Copy link

Hi @justrhysism! I know it's been a while, but I'm using your engine to build our internal component library, and this would be my most requested feature. Any chance of this feature being added?

@justrhysism
Copy link
Owner Author

Hi @doctyper, which bundler are you using? Using Vite I've had success leveraging this: https://www.npmjs.com/package/vite-plugin-full-reload

It's not HMR, but I've found it's fast enough in most cases.

Otherwise I haven't been able to find a way to make it "native" to the engine.

@doctyper
Copy link

@justrhysism We're using Webpack, and yeah I haven't found a way to HMR templates yet. I did come across this repo which does hot reload liquid templates, so I'm trying to decipher how exactly it's done and maybe port it over.

@justrhysism
Copy link
Owner Author

@doctyper I can't remember if Storybook exposes access to the Webpack Dev Server config, but that's where I'd probably try to hook in a watcher which just triggers a reload.

I have been looking at the Storybook HTML framework which has some evidence of page reloading, but I haven't been able to get it working.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants