New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

generate_rules.php: remove assert if running PHP8+ #486

Open

bohwaz opened this issue Mar 23, 2024 · 1 comment

Contributor

bohwaz commented Mar 23, 2024

assert() can no longer run any PHP code from PHP 8.0+

So it should no longer be a restricted function I think.

Owner

jvoisin commented Mar 24, 2024 •

edited

Loading

According to the documentation:

Prior to PHP 8.0.0, if assertion was a string it was interpreted as PHP code and executed via eval(). This string would be passed to the callback as the third argument. This behaviour was DEPRECATED in PHP 7.2.0, and REMOVED in PHP 8.0.0.

You're absolutely right, feel free to send a pull-request to remove it for php8.0+ :)

bohwaz mentioned this issue

Don't forbid use of assert in PHP 8+ #488

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment