From c931dc9f7a3de2b5e9f9931125c5023e3ab37055 Mon Sep 17 00:00:00 2001 From: pipefan413 <56257478+pipefan413@users.noreply.github.com> Date: Wed, 30 Oct 2019 16:25:31 +0000 Subject: [PATCH 1/3] Minor corrections to README.md Typos ("if focused", "isses"); phrasing sounded like non-native English in places. Also specifies "JPEG photo" throughout but the app obviously works for any JPEG image, not just photos. --- README.md | 14 +++++--------- 1 file changed, 5 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index bbb8550..e06350f 100644 --- a/README.md +++ b/README.md @@ -1,17 +1,13 @@ -LLCrop allows either [removal of unwanted outer areas from a JPEG-photo](https://en.wikipedia.org/wiki/Cropping_(image)) +LLCrop allows either [removal of unwanted outer areas from a JPEG image](https://en.wikipedia.org/wiki/Cropping_(image)) or creation of zoom-ins. -Load a JPEG photo, make a rectangular selection, to be saved as a new photo-file. +Load a JPEG image, adjust the rectangular selection and save it as a new image file. -While there are many apps capable of cropping images (some with additional features) these apps cause [quality-losses caused by reencoding of JPEG](https://en.wikipedia.org/wiki/Lossy_compression). +While there are many apps capable of cropping images (some with additional features) these apps cause quality loss because they [reencode when saving the output file](https://en.wikipedia.org/wiki/Lossy_compression). -LLCrop ("ll" stands for lossless) can do [cropping without quality-losses](https://en.wikipedia.org/wiki/Lossy_compression#JPEG) because it crops the raw JPEG photo, without -the need to reencode the JPEG image. It also preserves embedded metadata (EXIF/IPTC and XMP). +LLCrop ("LL" stands for lossless) can [crop JPEG images without quality loss](https://en.wikipedia.org/wiki/Lossy_compression#JPEG) because it crops the raw JPEG photo, without the need to reencode the JPEG image. It also preserves embedded metadata (EXIF/IPTC and XMP). -Note: - -This app if focused on "lossless jpg" image manipulation so isses that propose additional features -like "add text to image" or support "png" file format are out of scope. +Note: This app is focused on "lossless jpg" image manipulation, so issues that propose additional features (e.g. support for other file formats or adding text to images) are out of scope. --- From dccb5075269501880e1eddc3e7146fddfba747ce Mon Sep 17 00:00:00 2001 From: pipefan413 <56257478+pipefan413@users.noreply.github.com> Date: Wed, 30 Oct 2019 16:43:29 +0000 Subject: [PATCH 2/3] Further adjustments for consistency and phrasing The first sentence makes it sound like a zoom-in is somehow different from a crop, which it isn't, and I think everybody knows what cropping is without having to read the Wikipedia page about it. Rearranged the rest and made it sound a tad more professional. --- README.md | 15 ++++++--------- 1 file changed, 6 insertions(+), 9 deletions(-) diff --git a/README.md b/README.md index e06350f..ce46047 100644 --- a/README.md +++ b/README.md @@ -1,21 +1,18 @@ -LLCrop allows either [removal of unwanted outer areas from a JPEG image](https://en.wikipedia.org/wiki/Cropping_(image)) -or creation of zoom-ins. +While there are many apps capable of cropping images (often with additional features) these generally cause quality loss because they [re-encode to JPEG again](https://en.wikipedia.org/wiki/Lossy_compression) when saving the output file. -Load a JPEG image, adjust the rectangular selection and save it as a new image file. +LLCrop (the "LL" stands for lossless) can [crop JPEG images without quality loss](https://en.wikipedia.org/wiki/Lossy_compression#JPEG) because it crops the raw JPEG image without re-encoding the file. It also preserves embedded metadata (EXIF/IPTC and XMP). -While there are many apps capable of cropping images (some with additional features) these apps cause quality loss because they [reencode when saving the output file](https://en.wikipedia.org/wiki/Lossy_compression). +Simply load a JPEG image from the in-app image browser, adjust the rectangular selection, and save it as a new image file. -LLCrop ("LL" stands for lossless) can [crop JPEG images without quality loss](https://en.wikipedia.org/wiki/Lossy_compression#JPEG) because it crops the raw JPEG photo, without the need to reencode the JPEG image. It also preserves embedded metadata (EXIF/IPTC and XMP). - -Note: This app is focused on "lossless jpg" image manipulation, so issues that propose additional features (e.g. support for other file formats or adding text to images) are out of scope. +Note: This app is focused on lossless JPEG image manipulation, so issues that propose additional features (e.g. support for other file formats or adding text to images) are out of scope. --- ## Supported Workflows: -* [#1](https://github.com/k3b/LosslessJpgCrop/issues/1) From Android **App-Launcher**: +* [#1](https://github.com/k3b/LosslessJpgCrop/issues/1) From Android **app launcher**: * Pick an image and crop it to a new public file -* [#1](https://github.com/k3b/LosslessJpgCrop/issues/1) From any **File manager** or **Gallery app** that supports [intent-action-EDIT](https://developer.android.com/reference/android/content/Intent#ACTION_EDIT) for MIME *image/jpeg*: +* [#1](https://github.com/k3b/LosslessJpgCrop/issues/1) From any **file manager** or **gallery app** that supports [intent-action-EDIT](https://developer.android.com/reference/android/content/Intent#ACTION_EDIT) for MIME *image/jpeg*: * Crop current selected image to a new public file * [#2](https://github.com/k3b/LosslessJpgCrop/issues/2): From any app that supports [intent-action-SEND](https://developer.android.com/reference/android/content/Intent#ACTION_SEND) or [intent-action-SEND-TO](https://developer.android.com/reference/android/content/Intent#ACTION_SENDTO) for MIME *image/jpeg* * Send/SendTo/Share a cropped version of the currently selected image From fdde769b69ad169e5d6691bec5084f4757d040d6 Mon Sep 17 00:00:00 2001 From: pipefan413 <56257478+pipefan413@users.noreply.github.com> Date: Wed, 30 Oct 2019 16:47:43 +0000 Subject: [PATCH 3/3] One last README fix First sentence needed a comma and "they" works better than "these" --- README.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/README.md b/README.md index ce46047..5061102 100644 --- a/README.md +++ b/README.md @@ -1,4 +1,4 @@ -While there are many apps capable of cropping images (often with additional features) these generally cause quality loss because they [re-encode to JPEG again](https://en.wikipedia.org/wiki/Lossy_compression) when saving the output file. +While there are many apps capable of cropping images (often with additional features), they generally cause quality loss because they [re-encode to JPEG again](https://en.wikipedia.org/wiki/Lossy_compression) when saving the output file. LLCrop (the "LL" stands for lossless) can [crop JPEG images without quality loss](https://en.wikipedia.org/wiki/Lossy_compression#JPEG) because it crops the raw JPEG image without re-encoding the file. It also preserves embedded metadata (EXIF/IPTC and XMP).