Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support set from HelmChartConfig #199

Open
chinglinwen opened this issue Jul 11, 2023 · 1 comment
Open

Support set from HelmChartConfig #199

chinglinwen opened this issue Jul 11, 2023 · 1 comment

Comments

@chinglinwen
Copy link

chinglinwen commented Jul 11, 2023 •
edited
Loading

Why HelmChartConfig doesn't have set field in Spec, which means can't override HelmChart resource's set values ?

Both should support set values? ( say merge HelmChartConfig set into HelmChart's set. )
@brandond
Copy link
Member

Use of set overrides everything from values, so those are effectively hard-coded and intentionally cannot be overridden by values from either the HelmChart or HelmChartConfig's ValuesContent. We intentionally don't allow further attempts to override these by allowing set on HelmChartConfig. What specifically are you trying to override that was passed via the set?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@brandond @chinglinwen