Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CreateNetworkStatuses should assign IP addresses to a default interface if one isn't specified. #74

Open
Brian-McM opened this issue Nov 22, 2024 · 0 comments

Comments

@Brian-McM
Copy link

Multus 4.1 started using CreateNetworkStatuses instead of CreateNetworkStatus in this PR. This broke the current default behaviour where an IP is assigned to a default address if it doesn't specify an interface index.

Upgrading multus to 4.1 breaks when using calico (and possibly other CNIs) since it doesn't specify the interface index. Calico should probably be updated to specific the interface index just to be explicit, but I think it is reasonable to have a default, especially since:

  1. This used to default the IPs to an interface
  2. It would be reasonable to default to an eth0 interface, just like containerd does here

In conjunction with this, I think it would also be reasonable to fail (and probably should fail) if it can't assign the IP addresses to an interface instead of silently dropping the IPs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant