Optionally avoid sleeping in entrypoint.sh
#289
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zeeke
force-pushed
the
avoid-sleep
branch
3 times, most recently
from
2278a5d to
71348e3
Compare
Eoghan1232
approved these changes
Feb 6, 2024
adrianchiris
reviewed
Feb 6, 2024
images/entrypoint.sh
Outdated
| @@ -6,6 +6,7 @@ set -e | |||
| # Set known directories. | |||
| CNI_BIN_DIR="/host/opt/cni/bin" | |||
| SRIOV_BIN_FILE="/usr/bin/sriov" | |||
| AVOID_SLEEP=0 | |||
images/entrypoint.sh
Outdated
| @@ -18,6 +19,7 @@ usage() | |||
| printf "\t-h --help\n" | |||
| printf "\t--cni-bin-dir=%s\n" "$CNI_BIN_DIR" | |||
| printf "\t--sriov-bin-file=%s\n" "$SRIOV_BIN_FILE" | |||
| printf "\t--avoid-sleep\n" | |||
Container image might be used as `initcontainers` in kubernetes Pods. In such scenarios, it's important for the image entrypoint to exits once the copy logic is completed. Otherwise, the pod would stuck in a `PodInitializing` phase. Add Makefile rule `image-test` to check the integrity of the entrypoint.sh script. https://kubernetes.io/docs/concepts/workloads/pods/init-containers/ Signed-off-by: Andrea Panattoni <[email protected]>
Pull Request Test Coverage Report for Build 7802222930
💛 - Coveralls |
adrianchiris
approved these changes
Feb 6, 2024
adrianchiris
merged commit 8136d36
into
k8snetworkplumbingwg:master
9 of 10 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Container image might be used as
initcontainersin kubernetes Pods. In such scenarios, it's important for the image entrypoint to exits once the copy logic is completed. Otherwise, the pod would stuck in aPodInitializingphase.Add Makefile rule
image-testto check the integrity of the entrypoint.sh script.https://kubernetes.io/docs/concepts/workloads/pods/init-containers/
refs:
{ib-}sriov-cnientrypoint script sriov-network-operator#581