Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Node Slice Fast IPAM Uses Incorrect Range Field When Specs Change #498

Open
ivelichkovich opened this issue Aug 27, 2024 · 1 comment

Comments

@ivelichkovich
Copy link
Contributor

Describe the bug
A clear and concise description of what the bug is.

https://github.com/k8snetworkplumbingwg/whereabouts/blob/master/pkg/node-controller/controller.go#L436 should use ipamConf.IPRanges[0].Range instead of ipamConf.Range like the if block above it that checks for the change to spec

Expected behavior
A clear and concise description of what you expected to happen.

Whereabouts node controller should handle spec changes

To Reproduce
Steps to reproduce the behavior:

  1. Create a NAD
  2. Change node_slice_size or ip_range

Environment:

  • Whereabouts version : latest main
  • Kubernetes version (use kubectl version): N/A
  • Network-attachment-definition: N/A
  • Whereabouts configuration (on the host): N/A
  • OS (e.g. from /etc/os-release): N/A
  • Kernel (e.g. uname -a): N/A
  • Others: N/A

Additional info / context
Add any other information / context about the problem here.

@ivelichkovich
Copy link
Contributor Author

Thanks @xagent003 for finding this, please help raise MR to fix 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant