Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Allow better naming in dashboard names #41

Open
angelbarrera92 opened this issue Sep 28, 2022 · 0 comments
Open

Bug: Allow better naming in dashboard names #41

angelbarrera92 opened this issue Sep 28, 2022 · 0 comments
Labels
enhancement New feature or request good first issue Good for newcomers

Comments

@angelbarrera92
Copy link
Member

Currently, the dashboard name set in the organization CR:

---
apiVersion: grafana.k8spin.cloud/v1
kind: Organization
metadata:
  name: example.com
  namespace: monitoring
spec:
  dashboards:
  - name: Pods
    data: |
      {}

can not be as friendly as it should be, for example, it can not contains special characters like / or because this name is being used to override the dashboard internal uid:

dashboardParsed['uid'] = dashboardName
dashboardParsed['title'] = dashboardName
and it does not accept this characters.

It would be awesome if this name accepts every possible character and the uid is not a problem anymore.
Check if the uid is required for anything else that could impact the operator logic.

@angelbarrera92 angelbarrera92 added enhancement New feature or request good first issue Good for newcomers labels Sep 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant