Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

Put proper language in html lang tag #155

Open
RoelN opened this issue Aug 18, 2017 · 3 comments
Open

Put proper language in html lang tag #155

RoelN opened this issue Aug 18, 2017 · 3 comments
Labels
enhancement

Comments

@RoelN
Copy link
Contributor

RoelN commented Aug 18, 2017

In project_template/src/index.html we have hardcoded the language:

<html lang="en">
...

Could this be derived and injected from some settings instead?
@pascalw
Copy link
Member

pascalw commented Feb 2, 2018

@RoelN I guess we could derive this from the current locale, but I wonder if it matters in any way? From what I can tell it's mainly used by search engines, which given the main target usage for Maji (Cordova apps) is not that important. What do you think?

@leonderijke
Copy link
Collaborator

Besides search engines there are a few other uses of the lang attribute:

  • it will choose the appropriate formats for date and number inputs
  • it is used by the OS spellchecker to help correct the user's spelling in input fields
  • it is used by screenreaders to determine the right language, accent and pronunciation

More information: https://www.w3.org/International/questions/qa-lang-why.en

@pascalw
Copy link
Member

pascalw commented Feb 5, 2018

Ok good to know. Let's implements this based on the current locale.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@pascalw @leonderijke @RoelN