Skip to content
This repository has been archived by the owner on Oct 6, 2021. It is now read-only.

make ios-deploy optional? #282

Open
ruisalgado opened this issue Feb 10, 2020 · 2 comments
Open

make ios-deploy optional? #282

ruisalgado opened this issue Feb 10, 2020 · 2 comments

Comments

@ruisalgado
Copy link
Member

ruisalgado commented Feb 10, 2020

building ios-deploy is riddled with issues in MacOS Catalina, from requiring --unsafe-perm=true to issues linking to xcode libraries during the build step. Its maintainers now recommend installing a pre-compiled binary via brew.
The current maji setup has the installation of ios-deploy and ios-sim
be triggered by a cordova hook, which means they get installed even if you're never going to use them (you wouldn't need them for example in a CI environment).
A better (?) approach could be to try to resolve these dependencies only when they are need (when running certain maji cli commands). At this point we might offer to install ios-deploy via brew as an alternative to npm, or at least educate the user about it.

@pascalw
Copy link
Member

pascalw commented Feb 11, 2020

Yeah ios-deploy has always been a PITA, but I didn't realize it had gotten even worse on Catalina.

I'm in favor of removing the code that installs the module automatically and just putting it as a prerequisite in the docs. WDYT?

@ruisalgado
Copy link
Member Author

sounds good to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants