Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reconsider default behavior around events #998

Open
kachick opened this issue Dec 27, 2024 · 1 comment · May be fixed by #1030
Open

Reconsider default behavior around events #998

kachick opened this issue Dec 27, 2024 · 1 comment · May be fixed by #1030
Labels
enhancement New feature or request

Comments

@kachick
Copy link
Owner

kachick commented Dec 27, 2024

What

Extracted from #771 (comment)

I think adding it only to the wait-list field is a good first step.

I may need to consider the second step, I have misused this action in skip-list.

https://github.com/kachick/irb-power_assert/actions/runs/12515010993/job/34911942968

  release.yml(Push gem to RubyGems.org): [eventName: push][runStatus: COMPLETED][runConclusion: SKIPPED][runURL: https://github.com/kachick/irb-power_assert/actions/runs/12515010984/job/34911937331]
  release.yml(Push gem to RubyGems.org): [eventName: push][runStatus: IN_PROGRESS][runConclusion: (null)][runURL: https://github.com/kachick/irb-power_assert/actions/runs/12515010993/job/34911942968]

How

  • Ignore other events by default
  • Add new flag for above
  • or...?
@kachick kachick added the enhancement New feature or request label Dec 27, 2024
@kachick
Copy link
Owner Author

kachick commented Feb 13, 2025

For example, if the GitHub provided dependabot updater failed.

Image

https://github.com/kachick/wait-other-jobs/actions/runs/13299120588

https://github.com/kachick/wait-other-jobs/actions/runs/13283094372/job/37085626817

This pattern will not be occurred for PRs, however executing for push, schedule, workflow_dispatch might have it.
Filtering with same event by default might be reasonable behavior.

@kachick kachick linked a pull request Feb 13, 2025 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant