Skip to content

Commit

Permalink
log: P2P task failures are logged at Debug, not Info
Browse files Browse the repository at this point in the history
P2P task failures that are followed by retries aren't very
interesting, but if they're past the retry limit that's more
interesting.

Change-Id: I982be55277f5637be4c28df1320f9643d1a9a064
  • Loading branch information
edmundnoble committed May 31, 2024
1 parent 4c494f0 commit 2952c7c
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 1 deletion.
2 changes: 2 additions & 0 deletions changes/2024-05-30T144824-0400.txt
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
Single P2P task failures are logged at Debug instead of Info level, while they're still being retried

2 changes: 1 addition & 1 deletion src/P2P/TaskQueue.hs
Original file line number Diff line number Diff line change
Expand Up @@ -199,7 +199,7 @@ session_ limit q logFun env = E.mask $ \restore -> do
let attempts = _taskAttemptsCount task'
if
| _taskAttemptsCount task' < limit -> do
logg task' Info $ "task failed: " <> sshow attempts
logg task' Debug $ "task failed: " <> sshow attempts
pQueueInsert q task'
return False
| otherwise -> do
Expand Down

0 comments on commit 2952c7c

Please sign in to comment.