From 2952c7c2dd9432d3449e7a14b89bb776c103c5fb Mon Sep 17 00:00:00 2001 From: Edmund Noble Date: Mon, 27 May 2024 14:07:33 -0400 Subject: [PATCH] log: P2P task failures are logged at Debug, not Info P2P task failures that are followed by retries aren't very interesting, but if they're past the retry limit that's more interesting. Change-Id: I982be55277f5637be4c28df1320f9643d1a9a064 --- changes/2024-05-30T144824-0400.txt | 2 ++ src/P2P/TaskQueue.hs | 2 +- 2 files changed, 3 insertions(+), 1 deletion(-) create mode 100644 changes/2024-05-30T144824-0400.txt diff --git a/changes/2024-05-30T144824-0400.txt b/changes/2024-05-30T144824-0400.txt new file mode 100644 index 0000000000..03013c957d --- /dev/null +++ b/changes/2024-05-30T144824-0400.txt @@ -0,0 +1,2 @@ +Single P2P task failures are logged at Debug instead of Info level, while they're still being retried + diff --git a/src/P2P/TaskQueue.hs b/src/P2P/TaskQueue.hs index b80b94fe71..0cb6392e4e 100644 --- a/src/P2P/TaskQueue.hs +++ b/src/P2P/TaskQueue.hs @@ -199,7 +199,7 @@ session_ limit q logFun env = E.mask $ \restore -> do let attempts = _taskAttemptsCount task' if | _taskAttemptsCount task' < limit -> do - logg task' Info $ "task failed: " <> sshow attempts + logg task' Debug $ "task failed: " <> sshow attempts pQueueInsert q task' return False | otherwise -> do