perf: use module cache output from readFrom #1972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
All of our time was being spent reading modules from the database, because the new readFrom didn't persist its cache back to the database state. I think originally the reason why it didn't was to avoid state leakage, but this is safe because the module cache is guaranteed correct (it just does JSON parsing). Change-Id: I405069a2ee17cfb4581df20402ff66c39675d90b
edmundnoble
force-pushed
the
push-npnkupryxorr
branch
from
96c1d21 to
061a8cd
Compare
chessai
approved these changes
Jun 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All of our time was being spent reading modules from the database, because the new readFrom didn't persist its cache back to the database state. I think originally the reason why it didn't was to avoid state leakage, but this is safe because the module cache is guaranteed correct (it just does JSON parsing).
Change-Id: I405069a2ee17cfb4581df20402ff66c39675d90b