fold in rocksdb libs with josh #1974
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chessai
force-pushed
the
chessai/fold-in-rocksdb-libs-with-josh
branch
from
9c85fa1 to
9153d5e
Compare
See convention #3 at http://code.google.com/p/leveldb/source/browse/include/leveldb/c.h The *errptr must be NULL, but previously that was not always so, because Haskell alloca, while allocates memory, does not zero-fill it.
Squashed commit of the following: commit 583f1499c00ff40f332149021f583cf6ee78dd7e Author: Sanjay Ghemawat <[email protected]> Date: Fri Mar 9 07:51:04 2012 -0800 fix LOCK file deletion to prevent crash on windows commit d79762e27369365a7ffe1f2e3a5c64b0632079e1 Author: Sanjay Ghemawat <[email protected]> Date: Thu Mar 8 16:23:21 2012 -0800 added group commit; drastically speeds up mult-threaded synchronous write workloads commit 015d26f8be6e27d96c536eb9f1ef7275898e3603 Author: Sanjay Ghemawat <[email protected]> Date: Mon Mar 5 10:35:46 2012 -0800 add .gitignore; support for building on a few BSD variants
Just patch Control.Monad.Trans.Resource to export some types and implement runResourceT as runLevelDB with custom alloc/dealloc strategy. Removes the re-export of teh whole Resource module.
* fixes #5 * Todo: * tweak foreign imports, possibly not all of them need to be 'safe' * maybe it's time to switch to record syntax for options to reduce clutter
Interestingly, this fixes segfaults with custom comparators.
Co-authored-by: Lars Kuhtz <[email protected]>
Change-Id: Ie1f22dab778d213c9419a4bf205815c07a7cb8a7
Change-Id: Idb25821f7830241b1c48c12a294b9bbe10a69497
Change-Id: I6e9707ee1ee3510a23c2791421dae396b96b653d
Change-Id: I277360bcfa40d1afcc1ce6147ada197c7676c2ec
Change-Id: Ie94dbcb79ad2fe82325b1c05cdbd19f8355c179c
Change-Id: I961cf573fc3b1bf48edeb46f653c3f6857dd6243
Change-Id: I505041b3ec2244af276190637f905862ca87075f
chessai
force-pushed
the
chessai/fold-in-rocksdb-libs-with-josh
branch
from
c95a4c0 to
a28b8a7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.