delete checkpointer abstraction #2054
Merged
+525
−995
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the term |
|
Yeah fair point, I can rename it to |
Alternatively, we could also move away from the current (not ideal) terminology and use a more specific term for those ephemeral records. It's just to avoid confusion. |
edmundnoble
force-pushed
the
push-qzuvyrzlpvwn
branch
2 times, most recently
from
4370147 to
d891e23
Compare
chessai
approved these changes
Dec 9, 2024
edmundnoble
force-pushed
the
push-qzuvyrzlpvwn
branch
from
d891e23 to
fdc06e2
Compare
chessai
approved these changes
Dec 9, 2024
Replace the checkpointer abstraction with a concrete `CheckpointerResources` type. Consider the original RelationalCheckpointer code to be the "internal" portion of the checkpointer. Use qualified imports to refer to the checkpointer from PactService so that it's clear what's owned by it.
edmundnoble
force-pushed
the
push-qzuvyrzlpvwn
branch
from
fdc06e2 to
c22ab78
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace the checkpointer abstraction with a concrete
CheckpointerResourcestype. Consider the original RelationalCheckpointer code to be the "internal" portion of the checkpointer. Use qualified imports to refer to the checkpointer from PactService so that it's clear what's owned by it.