pact5 review phase 1 #2066
Open
pact5 review phase 1 #2066
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I checked that libmpfr6 exists for both Jammy (Ubuntu 22) and Focal (Ubuntu 20) and libmpfr-dev is the version with headers.
It was unused but is already a sort of flawed idea; usually the parent header is what should be guarded by.
This puts more Pact 4- and 5-specific code into their respective specific files, as well as moving some of the more general code to the more general file. Some more qualified imports are used as well to clear up any ambiguity and stop using version-specific code in version-non-specific codepaths.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address review. These commits are meant to be reviewed individually.