Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable automatic "lang" attribute setting #249

Open
jonaswascheroh opened this issue May 29, 2024 · 1 comment
Open

Disable automatic "lang" attribute setting #249

jonaswascheroh opened this issue May 29, 2024 · 1 comment
Labels
good first issue Good for newcomers

Comments

@jonaswascheroh
Copy link

jonaswascheroh commented May 29, 2024

Is your feature request related to a problem? Please describe.
I am using this library for an embedded widget that is integrated into other companies websites.
I only just realized now that this library is automatically setting the "lang" attribute on the html tag, whenever the internalLocale is changed.
This is mixing up our customers websites.

Describe the solution you'd like
I would like to have the option in the init method to disable the automatic attribute setting.

How important is this feature to you?
Very important as there is currently no other way to do it.

@kaisermann kaisermann added the good first issue Good for newcomers label Jun 11, 2024
@jonaswascheroh
Copy link
Author

@kaisermann First I thought I could avoid this problem in my application but now it seems that even with no rendering of my application this library is being executed when the JavaScript ran. That means, that it sets the HTML "lang" attribute to null or empty string even though there is never a call of the "init" method.
Do you have any ideas how to fix this?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

2 participants