Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Discuss] Merge the comments of a single PR #147

Open
morningman opened this issue Aug 31, 2021 · 1 comment
Open

[Discuss] Merge the comments of a single PR #147

morningman opened this issue Aug 31, 2021 · 1 comment
Labels
enhancement New feature or request

Comments

@morningman
Copy link
Collaborator

Is your feature request related to a problem? Please describe.

When we submit multiple comments to a PR, osschat will send each comment one by one. This will cause the WeChat group to be received too many notification.

Describe the solution you'd like

[enhancement]

@morningman morningman added the enhancement New feature or request label Aug 31, 2021
@huan
Copy link
Collaborator

huan commented Sep 1, 2021

There are more decisions that need to be made to merge comments.

For example, how long should we wait for another comment when we received one comment before we send it to the WeChat room? 1 minute? 3 minute?

How can we implement this feature, for example, how to design a manageable storage structure to deal with those comments?

I'd like to accept a PR for this feature if there's anyone like to submit one, and we can continue discussing based on the PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants