Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Not able to roll Crits with Foundry native rolls #1073

Open
Dhrunn opened this issue Jul 8, 2023 · 3 comments
Open

Not able to roll Crits with Foundry native rolls #1073

Dhrunn opened this issue Jul 8, 2023 · 3 comments
Assignees
Labels
bug Something isn't working

Comments

@Dhrunn
Copy link

Dhrunn commented Jul 8, 2023

If i try to roll a critical strike with foundry native rolls it just rolls the normal damage and no additional dice.

Screenshot 2023-07-08 220522

i found that the damage formula is written in Brackets
Screenshot 2023-07-08 220756

if i delete the brackets and write it like 1d6+3[Slashing] i would be able to roll crit damage. But as son as i roll out of DnD Beyond again the formula is written with brackets again. Anyone else encountered this issue and know how to fix it?

@Dhrunn Dhrunn added the bug Something isn't working label Jul 8, 2023
@Aeristoka
Copy link
Collaborator

@kakaroto this looks like one for you.

@kakaroto
Copy link
Owner

kakaroto commented Jul 9, 2023

That is a dnd5e system bug unfortunately... It had been mentioned when adding the native support when talking to the midi-qol devs here: https://gitlab.com/tposney/midi-qol/-/issues/1087
The issue above also explains why the parenthesis are required in the formula, if you want to read that conversation.

I didn't remember the issue until now but looks like we had known about it before, and it had been reported to the dnd5e developers, who fixed it I assume, and last month, it was reported again by someone else as a regression (i.e something that was fixed but then broken again in a subsequent release) here: foundryvtt/dnd5e#2343
Nothing to do on your side other than wait for the dnd5e system developers to fix the logic for crits on their side.

@Dhrunn
Copy link
Author

Dhrunn commented Jul 11, 2023

allright thanks for the realy fas response. We just paused our campain for1.5 month so it makes sense that the issue is kinda new for me. Thanks for your great work!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants