Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add ability to override any global setting on a per-character basis #999

Open
Rarst opened this issue Jul 3, 2022 · 5 comments
Open

Add ability to override any global setting on a per-character basis #999

Rarst opened this issue Jul 3, 2022 · 5 comments
Milestone

Comments

@Rarst
Copy link

Rarst commented Jul 3, 2022

Is your feature request related to a problem? Please describe.
Critical hit rules is one of the best features for me (since D&D Beyond doesn't natively support alternate rules), however it is likely to differ between campaigns and it is a little buried / hard to see current setting.

Describe the solution you'd like

  1. It would make sense if critical hit rules could bet set per campaign (similar to how Character Specific Options are handled)
  2. Alternately just relocating it to the initial tab (e.g. next to Force Critical Hits) would improve visibility and lower mistakes from having a wrong setting for the campaign
@Aeristoka
Copy link
Collaborator

So a couple of points here:

There is no "per campaign" setting. Beyond20 has no concept of that, as it is parsing Character sheets/NPC Sheets.

Character Specific are literally that because of what is parsed on that particular character sheet.

"Force Crits" is exposed on the main page of options because it is a core part of the D&D 5e Ruleset (if you attack an unconscious character with a melee attack within 5 feet it is an auto-crit in example).

The Homebrew Critical options are NOT a part of the core D&D 5e Ruleset at all, but they are a thing that @kakaroto included (the most used two that he was aware of when they were added), thus they are buried deeper in the settings as 99% of the time or more, it is 100% unnecessary to change.

All that said, I'll need to discuss this with @kakaroto and see what he thinks.

@Rarst
Copy link
Author

Rarst commented Jul 3, 2022

as 99% of the time or more, it is 100% unnecessary to change

If all of your games use standard critical rules, it's never necessary to change.

However if even one of your games uses alternate rules, you have to check that before every game or you'll roll wrong stuff and then have to change it and re-roll in the middle of the game.

A more conservative improvement might be to show it prominently if it's set to anything other than standard rules. Same status quo for players with defaults, better experience for players who have to deal with it every time.

@kakaroto
Copy link
Owner

kakaroto commented Jul 6, 2022

That's not a setting I'd like to have be per-character, but I do like the idea of having a more generic per-character "override global setting" which would allow you to override the crit rules or any other setting for a specific character (like, use digital dice only for this character, or don't auto roll damages, etc...)

@kakaroto kakaroto changed the title Critical hit rules handling between different campaigns Add ability to override any global setting on a per-character basis Jul 6, 2022
@Rarst
Copy link
Author

Rarst commented Jul 6, 2022

My thinking was bogged on campaign level for it (because rule is decided by DM on that level), but handling it on character level works too and already has precedent.

However that would makes sense for you, thank you for considering. :)

@kakaroto kakaroto added this to the Next release milestone Aug 7, 2022
@kakaroto
Copy link
Owner

kakaroto commented Oct 2, 2022

This is turning out to be more complex than I thought, and I just can't imagine how to do it in the user interface. If you have suggestions on how it could be done so the UI is not confusing and the feature is usable, then let me know, until then, I'm bumping it to a future release instead.

@kakaroto kakaroto modified the milestones: 2.8.0, Next-next-release Oct 2, 2022
@kakaroto kakaroto modified the milestones: 2.9.0, Far future Jun 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants