Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Input data structure for molecule #10

Closed
EasternCaveMan opened this issue Jan 25, 2024 · 2 comments
Closed

Input data structure for molecule #10

EasternCaveMan opened this issue Jan 25, 2024 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@EasternCaveMan
Copy link

EasternCaveMan commented Jan 25, 2024

Hi Roman,

I've noticed that DataSAIL doesn't currently accept InChI as input for molecules. However, I'm wondering if I could convert the InChI to ECFP and then provide it as input to DataSAIL? It seems that converting InChI to SMILES is quite risky, as indicated in these discussions:
rdkit/rdkit#542
https://sourceforge.net/p/rdkit/mailman/message/36696861/

It would significantly enhance usability if DataSAIL could also accept ECFP as input for molecules, making it more universal.

@Old-Shatterhand Old-Shatterhand added the enhancement New feature or request label Jan 29, 2024
@Old-Shatterhand Old-Shatterhand self-assigned this Jan 29, 2024
@Old-Shatterhand
Copy link
Member

Yes, fingerprint input may be an idea. What's also possible is to calculate the similarity-matrix on your own and input that with the --e-sim argument as in this example.

@Old-Shatterhand Old-Shatterhand added this to the Version v1.0.0 milestone Mar 14, 2024
@Old-Shatterhand
Copy link
Member

Old-Shatterhand commented Apr 4, 2024

This has been solved with commit 35954ce and in PR #22.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants