Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support other clustering algorithms #25

Open
isty2e opened this issue May 10, 2024 · 1 comment
Open

Support other clustering algorithms #25

isty2e opened this issue May 10, 2024 · 1 comment
Labels
enhancement New feature or request

Comments

@isty2e
Copy link

isty2e commented May 10, 2024

Is your feature request related to a problem? Please describe.
This is not a problem per se, but AgglomerativeClustering and SpectralClustering in sklearn.cluster is not always favorable especially for large datasets due to its numerical scaling (benchmark at HDBSCAN docs. For example, personally I usually use genieclust, and would like to use it instead of sklearn clusterers, which is impossible in the current implementation.

Describe the solution you'd like
A Clusterer base class for interfacing both sklearn and other types of clusterers by inheritance can be implemented and its instance (or class itself) can be given as an argument while splitting. Or it can be some if-else statements in datasail.cluster.clustering.additional_clustering(), but it might be less elegant.

Describe alternatives you've considered
Alternatively, sklearn clusterers can be replaced with ones from fastclust package.

@isty2e isty2e added the enhancement New feature or request label May 10, 2024
@Old-Shatterhand
Copy link
Member

Dear @isty2e,

Thank you for your feedback and suggestions. We will definitely consider these for future versions and improvements of DataSAIL. Customized clustering is indeed something we haven't thought about and implemented yet.

Best, Roman

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants