Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clarify difference between auk-panel--gray-100 and auk-panel--editing #9

Open
MikiDi opened this issue Jun 9, 2021 · 1 comment
Open
Assignees

Comments

@MikiDi
Copy link
Collaborator

MikiDi commented Jun 9, 2021

auk-panel--gray-100 vs auk-panel--editing. Apart from 1 unit of difference for the R component, both result in the same colour value. Do both of these classes exist next to each other on purpose, or should one of both be deprecated? In case both should be kept, clarify when to use which by means of a comment.

@brenner-company
Copy link
Contributor

@MikiDi I don't know if you can see the following file (https://github.com/mono-company/kaleidos-prototype-v3/blob/master/content/js/modules/editable-panels.js), but the class they use at Mono within the prototypes is auk-panel--gray-100. Seems more logical & reusable then auk-panel--editing.

Is the following OK for you? Replacing auk-panel--editing within Kaleidos codebase and, after that, removing the class from this package?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

No branches or pull requests

2 participants