-
Notifications
You must be signed in to change notification settings - Fork 122
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: flaky test #92
Open
miparnisari
wants to merge
1
commit into
karlseguin:master
Choose a base branch
from
miparnisari:fix-flaky-test
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
fix: flaky test #92
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,6 +1,7 @@ | ||
package ccache | ||
|
||
import ( | ||
"fmt" | ||
"math/rand" | ||
"sort" | ||
"strconv" | ||
|
@@ -413,14 +414,15 @@ func Test_ConcurrentClearAndSet(t *testing.T) { | |
var wg sync.WaitGroup | ||
|
||
cache := New(Configure[string]()) | ||
wg.Add(1) | ||
r := func() { | ||
for !stop.Load() { | ||
cache.Set("a", "a", time.Minute) | ||
} | ||
wg.Done() | ||
} | ||
go r() | ||
wg.Add(1) | ||
|
||
cache.Clear() | ||
stop.Store(true) | ||
wg.Wait() | ||
|
@@ -432,20 +434,26 @@ func Test_ConcurrentClearAndSet(t *testing.T) { | |
// list is maintained by the background worker. This can create a period | ||
// where the two are out of sync. Even SyncUpdate is helpless here, since | ||
// it can only sync what's been written to the buffers. | ||
for i := 0; i < 10; i++ { | ||
assertEventually(t, func() bool { | ||
expectedCount := 0 | ||
if cache.list.Head != nil { | ||
expectedCount = 1 | ||
} | ||
actualCount := cache.ItemCount() | ||
if expectedCount == actualCount { | ||
return | ||
} | ||
time.Sleep(time.Millisecond) | ||
return expectedCount == actualCount | ||
}, 100, 50*time.Millisecond, fmt.Sprintf("cache list and lookup are not consistent in iteration %v", i)) | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. It doesn't matter what numbers I pass here, i always get a failure. @karlseguin are you sure this test is correct? I'm not familiar with the internals very well to understand what you are trying to test. |
||
} | ||
} | ||
|
||
func assertEventually(t *testing.T, assertion func() bool, maxRetry int, waitTime time.Duration, failmessage string) { | ||
for i := 0; i < maxRetry; i++ { | ||
if assertion() { | ||
return | ||
} | ||
t.Errorf("cache list and lookup are not consistent") | ||
t.FailNow() | ||
time.Sleep(waitTime) | ||
} | ||
// log and fail | ||
t.Fatalf(failmessage) | ||
} | ||
|
||
func BenchmarkFrequentSets(b *testing.B) { | ||
|
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://pkg.go.dev/sync#WaitGroup.Add:~:text=the%20calls%20to%20Add%20should%20execute%20before%20the%20statement%20creating%20the%20goroutine%20or%20other%20event%20to%20be%20waited%20for.