New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Should we add building checking in Pull Request? #175

Open

samzong opened this issue Jan 21, 2025 · 1 comment

Labels

Member

samzong commented Jan 21, 2025

What would you like to be added:

Why is this needed:

Avoid making this mistake again #172

@RainbowMango @warjiang

samzong added the kind/feature label

Member

RainbowMango commented Jan 21, 2025

See https://github.com/karmada-io/dashboard/blob/main/.github/workflows/ci.yml.

The mistake in #172 is for push images after PR gets merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment