Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

gracefulEvictionTasks can not be removed from rb when cluster returns to normal #5803

Open
spiritNO1 opened this issue Nov 11, 2024 · 5 comments
Labels
kind/question Indicates an issue that is a support question.

Comments

@spiritNO1
Copy link
Contributor

Please provide an in-depth description of the question you have:

My member cluster sometimes returns error when deal with readyz, so taint_manager patch gracefulEvictionTasks on all related rbs. But after a while the member cluster returns to ready, gracefulEvictionTasks shoule be removed from rb?

What do you think about this question?:

Environment:

  • Karmada version:
  • Kubernetes version:
  • Others:
@spiritNO1 spiritNO1 added the kind/question Indicates an issue that is a support question. label Nov 11, 2024
@spiritNO1
Copy link
Contributor Author

@RainbowMango I think taint_manager should recover rbs after the cluster returns to ready. How do you think?
image

@spiritNO1
Copy link
Contributor Author

Or I could turn off the Failover fature gate

@RainbowMango
Copy link
Member

so taint_manager patch gracefulEvictionTasks on all related rbs.

What happened after the taint manager built the gracefulEvictionTask? Does the failover perform as expected?

@spiritNO1
Copy link
Contributor Author

spiritNO1 commented Nov 12, 2024

so taint_manager patch gracefulEvictionTasks on all related rbs.

What happened after the taint manager built the gracefulEvictionTask? Does the failover perform as expected?

The scheduler reschedule the rb, and since the only affinity cluster is evicted, the schedule result is empty. And the update is stuck.

@RainbowMango
Copy link
Member

Well, I would say that's exactly the case we will improve. We hope to introduce pre-checks before performing eviction, for cases like this won't trigger failover.

Anyway, If you don't need the failover feature, you can always disable it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/question Indicates an issue that is a support question.
Projects
None yet
Development

No branches or pull requests

2 participants