Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

miscellaneous indexer improvements: 1) Seperate reindexing logic from the index. #414

Open
D-Stacks opened this issue Jan 27, 2024 · 0 comments

Comments

@D-Stacks
Copy link
Collaborator

D-Stacks commented Jan 27, 2024

  1. Currently reindexing logic is done within the index while holding it's lock
  2. This should be possible to do outside of the write lock.

ideally we would want a per consensus notification reindexer to perform the reindex inside the index processor and then simply supply the result to the index for committance to its Db.

A per consensus notification approach should be preferred, as

    1. the index processor processes on a per notification basis,
    1. reindexer looping and logic can supply reindexed notification conversion results separately for each index wanting information from a certain notification, without potentially re-preforming looping and certain logic from scratch.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant