-
Notifications
You must be signed in to change notification settings - Fork 130
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
straight quotes rendered as curved quotes in inline src blocks #640
Comments
@pdcawley Heads up! The required CSS will need to change as I adjust ox-hugo's export to implement a workaround for this limitation in Hugo's Commonmark parser. |
kaushalmodi
added a commit
that referenced
this issue
May 22, 2022
- Before: Inline src block classes were in the HTML code element - Now: The inline src block classes are in HTLM span tags wrapping Markdown `verbatim` block. Fixes #640.
kaushalmodi
added a commit
that referenced
this issue
May 23, 2022
- Before: Inline src block classes were in the HTML code element - Now: The inline src block classes are in HTLM span tags wrapping Markdown `verbatim` block. Fixes #640.
kaushalmodi
added a commit
that referenced
this issue
May 23, 2022
- Before: Inline src block classes were in the HTML code element - Now: The inline src block classes are in HTLM span tags wrapping Markdown `verbatim` block. Fixes #640.
Cool! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
@pdcawley Or you can see this update ox-hugo test: https://ox-hugo.scripter.co/test/posts/inline-code-blocks/#using-custom-css-for-inline-src-blocks
Aside.. looks like we triggered a bug in Hugo.. the smart quotes rendering done by GoldMark happens inside the HTML
code
elements too!See https://bug-smart-quote-conversion-in-code-element--hugo-mwe.netlify.app/posts/double-quotes-in-html-code-elements/
Originally posted by @kaushalmodi in #638 (comment)
Upstream Issues:
<code>
and related HTML elements untouched by CommonMark parser commonmark/commonmark-spec#711The text was updated successfully, but these errors were encountered: