Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Query params are cleared every time the user opens the Filter modal #405

Open
zainfathoni opened this issue Jul 25, 2021 · 0 comments
Open
Assignees
Labels
bug Something isn't working hacktoberfest Issues for Hacktoberfest

Comments

@zainfathoni
Copy link
Member

zainfathoni commented Jul 25, 2021

Description

After #384 implementation, a minor bug is also a suspect of this slow modal opening.
Whenever we open the Filter modal, the query params are cleared, which eventually clears the current filter & sort as well.
It causes the ContactList component to be rerendered.

Screen.Recording.2021-07-25.at.18.27.27.mov

Expected Behaviour

Opening the Filter modal should persist the query params.

Additional Information

If this bug is solved, there's a high chance that the slow modal opening will be resolved.

@zainfathoni zainfathoni added the bug Something isn't working label Jul 25, 2021
@zainfathoni zainfathoni removed their assignment Aug 21, 2021
@zainfathoni zainfathoni added the hacktoberfest Issues for Hacktoberfest label Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working hacktoberfest Issues for Hacktoberfest
Projects
None yet
Development

No branches or pull requests

3 participants