Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement search functionality in Database & Province page #86

Closed
Tracked by #17
zainfathoni opened this issue Jul 16, 2021 · 3 comments · Fixed by #88
Closed
Tracked by #17

Implement search functionality in Database & Province page #86

zainfathoni opened this issue Jul 16, 2021 · 3 comments · Fixed by #88

Comments

@zainfathoni
Copy link
Member

No description provided.

@ekamuktia
Copy link
Collaborator

It'll be great if there's filter based on Kebutuhan / Lokasi for easier access

Plus, for better search result maybe full text search can be used?
Some library:
https://www.npmjs.com/package/itemsjs (with aggregation to support the filter)
https://www.npmjs.com/package/minisearch

@zainfathoni
Copy link
Member Author

Sorry, I just read your comment right after I finished implementing and merging #88 😅

I also learnt from @resir014 that there's another search library named Fuse.js.

I think they are good options to improve our current search functionality, and we can take a closer look at them and try to use them in our implementation as an enhancement on top of my basic implementation.

@zainfathoni
Copy link
Member Author

zainfathoni commented Jul 17, 2021

Let's work on it at #111, thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants