Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Memory leak in http 5.3.6 #154

Closed
edsko opened this issue Nov 23, 2024 · 2 comments
Closed

Memory leak in http 5.3.6 #154

edsko opened this issue Nov 23, 2024 · 2 comments

Comments

@edsko
Copy link
Collaborator

edsko commented Nov 23, 2024

The below is a memory profile of a client using http2-5.3.5 who makes repeated connections to a server and then has a short interaction with the server on that connection before closing it again and starting again:

image

With http-5.3.6 this profile looks like this instead:

image

I will try to figure out whta's happening and submit a PR.

@edsko
Copy link
Collaborator Author

edsko commented Nov 23, 2024

(The leak is still present in 5.3.7 also.)

edsko added a commit to edsko/http2 that referenced this issue Nov 23, 2024
See `ManagedThreads`.

Closes kazu-yamamoto#154.
@edsko
Copy link
Collaborator Author

edsko commented Dec 4, 2024

Confirmed that this leak is gone as of #156, and no new memory leak was introduced in the time-manager-0.2 refactoring (see also #155 (comment)).

@edsko edsko closed this as completed Dec 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant