Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strict C# formatting #55

Open
wants to merge 4 commits into
base: master
Choose a base branch
from

Conversation

mikechamberlain
Copy link

No description provided.

@kbilsted
Copy link
Owner

kbilsted commented Jan 9, 2019

Hi Mike.

Thanks for the PR :-)

Is there a test that shows the new behaviour the diff in the commit seems not to convey the new functionality?

Should there be a strict option in the c# formatter instead? what are the design decisions for a separate formatter?

@mikechamberlain
Copy link
Author

Hi Kasper,

Not quite sure what you are asking as there are tests included in the PR. For context, I referenced this PR from the original issue #54. Though I got close, I never got to this work 100%, as you can see from the failing test.

My changes were good enough for my needs (I just fixed the invalid output by hand). Unfortunately I don't have time to look at this right now. If you think strict C# output is useful feature then hopefully you or someone else will be able to make it work. I think it's pretty close right now.

@kbilsted kbilsted force-pushed the master branch 4 times, most recently from 0bb972a to 768cc8c Compare January 19, 2019 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants