-
-
Notifications
You must be signed in to change notification settings - Fork 71
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace config struct with a config crate #605
Comments
I would like to move I really like the idea of using a |
I think sticking to a |
https://docs.rs/toml_edit/latest/toml_edit/ may be interesting, as it could allow us to edit the config in place. |
Description
Our current config struct is both error-prone and tedious to extend(many getters, non-standard ways of setting defaults).
While not a major concern, it also recomputes a lot, adding 10-50ms to startup(depending on hardware and .taskrc)
Solution
Replace our config struct with an implementation derived from one of the major config crates, like config or comfique.
This would also make the transition to our own config file easier, as we could add it and task _shows output both as sources to the config builder.
Additional context
If possible a config struct behind something like an Arc<Mutex<>> would be ideal, to futureproof both for config reloading and more robust async/multithreading.
The text was updated successfully, but these errors were encountered: