Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: shortcut to set priority are now hardcoded #533

Merged
merged 1 commit into from
Jan 16, 2024

Conversation

katekorsaro
Copy link
Contributor

By pressing H, M, L and N now the user has the possibility to set priority to selected task(s). No custom script is needed.

@kdheepak, I took the liberty of implementing some hardcoded shortcuts. I've searched through the issues but this doesn't seem to be mentioned. Though I find it useful (at least for my workflow).
I don't know if this will be broken by your refactor, but you can think of it as a temp unstable feat ☺️

I've also updated the help page with the new bindings.

@katekorsaro katekorsaro force-pushed the feat-priority-shortcuts branch from 9b54b8d to 37b9e5b Compare January 16, 2024 11:47
@kdheepak
Copy link
Owner

Thanks for a PR! Good job digging through my code and figuring this out, I know it is a mess and I appreciate you looking into it!

I like this functionality!

But I'd like to make it work slightly different. First, I think there shouldn't be a key defined by default, and the user would manually have to add key shortcuts to the config file. Because my understanding is that priorities in taskwarrior can be any string, right? So we'd want to configure any number of keys for any number of priorities. I can imagine this being implemented as a "increment priority" and "decrement priority". But I'll need to do the refactor first to get there unfortunately.

That said, I think I'd be okay to merge this as an undocumented unstable feature :) Can you remove the documentation for it? And I'll experiment with it locally and get back to you!

By pressing H, M, L and N now the user has the possibility to set priority to selected task(s).
No custom script is needed.
@katekorsaro katekorsaro force-pushed the feat-priority-shortcuts branch from 37b9e5b to 9158d00 Compare January 16, 2024 15:54
@katekorsaro
Copy link
Contributor Author

Ok, I amended the last commit reverting the documentation!

You're right, taskwarrior lets you state your priority strings and a full rework might be needed. In the meantime, this would be enough for a "default" behaviour.

@kdheepak kdheepak merged commit 5e9c22a into kdheepak:main Jan 16, 2024
10 of 11 checks passed
@kdheepak
Copy link
Owner

Awesome! Thank you!

@katekorsaro katekorsaro deleted the feat-priority-shortcuts branch January 16, 2024 18:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants