Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement protections to minimize risk that a panic in a scaler impacts the operator execution #6162

Closed
swgriffith opened this issue Sep 13, 2024 · 2 comments
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity

Comments

@swgriffith
Copy link

Proposal

I recently came across and documented the following bug in which the Github Runner Scaler can cause a panic with a simple typo in a parameter in the scaled job manifest. This panic put the KEDA operator itself into a crashloop. It would be good to add some protection in the call flow to capture panics introduced by a scaler and avoid impacting the operator as a whole.

#6156

Use-Case

Wrap the call to the scaler such that a panic within the scaler code is trapped, logged accordingly and the operator continues executing any other scaling activities on the cluster.

Is this a feature you are interested in implementing yourself?

No

Anything else?

No response

@swgriffith swgriffith added feature-request All issues for new features that have not been committed to needs-discussion labels Sep 13, 2024
Copy link

stale bot commented Nov 13, 2024

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 7 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale All issues that are marked as stale due to inactivity label Nov 13, 2024
Copy link

stale bot commented Nov 23, 2024

This issue has been automatically closed due to inactivity.

@stale stale bot closed this as completed Nov 23, 2024
@github-project-automation github-project-automation bot moved this from To Triage to Ready To Ship in Roadmap - KEDA Core Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature-request All issues for new features that have not been committed to needs-discussion stale All issues that are marked as stale due to inactivity
Projects
Status: Ready To Ship
Development

No branches or pull requests

1 participant